kubeflow / sdk / 17487937699

66%

push

github

feat: Support multiple pip index URLs in CustomTrainer (#79)

* feat: Support multiple pip index URLs in CustomTrainer

- Add pip_index_urls parameter to CustomTrainer (list of URLs)
- Update constants to support multiple URLs with environment variable
- Modify utils to handle multiple index URLs in pip installation
- Update tests to use new parameter
- Fix mutable default issue with dataclasses.field(default_factory=...)

Closes #72

Signed-off-by: wassimbensalem <bswassim@gmail.com>

* test: add comprehensive test cases for multiple pip index URLs

Signed-off-by: wassimbensalem <bswassim@gmail.com>

* refactor: simplify constants for pip index URLs

Signed-off-by: wassimbensalem <bswassim@gmail.com>

* fix: remove Optional from pip_index_urls docstring to match implementation

Signed-off-by: wassimbensalem <bswassim@gmail.com>

* test: adjust unit test for get_custom_trainer

Signed-off-by: wassimbensalem <bswassim@gmail.com>

* fix: add missing Dict import in utils.py

Signed-off-by: wassimbensalem <bswassim@gmail.com>

* refactor: move test cases to utils_test.py and convert to parametrized format

Signed-off-by: wassimbensalem <bswassim@gmail.com>

* refactor: update utils test to use exact string matching instead of contains/not_contains checks

- Changed TestCase expected_output from Dict[str, Any] to str
- Replaced contains/not_contains logic with direct string equality
- Updated all test cases to specify complete expected script output
- Tests now assert the entire script returned by get_script_for_python_packages

Signed-off-by: wassimbensalem <bswassim@gmail.com>

* feat: add multiple pip index URLs support with comprehensive tests

- Add support for multiple pip index URLs in CustomTrainer
- Update constants to handle comma-separated environment variables
- Add integration test for multiple pip index URLs flow
- Update utils to generate correct pip install commands with --index-url and --extra-index-url
- Ensure backward compatibility with... (continued)

3 of 4 new or added lines in 1 file covered. (75.0%)

292 of 416 relevant lines covered (70.19%)

1.4 hits per line