Qiskit / qiskit / 17469670539

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix calls to `VF2PostLayout` after optimization loop at O3 (#14869)

* Do not run VF2PostLayout in level 3 if layout args are set

This commit fixes a bug in the construction of the preset pass manager
for optimization level 3. In Qiskit 2.1.0 we started running the
VF2PostLayout pass in strict mode at the end of the optimization stage.
However when that was added it neglected to have a check that the user
didn't specify an explicit layout with the `initial_layout` argument
or a specific layout method be used with the `layout_method` argument.
This meant even though the user requested a specific layout or layout
technique the preset pass managers would ignore that setting and
VF2PostLayout would potentially pick a different layout. This commit
fixes this by only running the VF2PostLayout pass if these settings are
not used.

Fixes #14867

* Actually apply layout if a better one is found in optimization

* Cleanup test code

* Remove unused import

* Add target condition before running vf2post

* Don't run if there are free nodes in strict mode

* Fix typo

* Use the correct rustworkx function in strict mode

* Fix release notes

Run Details

15 of 15 new or added lines in 3 files covered. (100.0%)

15 existing lines in 3 files now uncovered.

92195 of 104311 relevant lines covered (88.38%)

561549.32 hits per line