kubernetes-sigs / cloud-provider-azure / 17461276030

76%

master: 75%

Build Type

push

github

Committed by web-flow

Commit Message

[release-1.30] fix: Do not return early when pip.publicIPAddress is empty when check… (#9388)

* fix: Do not return early when pip.publicIPAddress is empty when checking the ownership

* fix TestEnsurePublicIPExistsCommon unit test failure for release-1.30

Fixed failing test case 'shall_update_pip_tags_if_there_is_any_change' by
adding service tags to the existing PIP in test data. Due to the cherry-picked
changes, PIPs without service tags are now treated as user-assigned PIPs and
don't have their tags updated by the system.

Added consts.ServiceTagKey to the existing PIP to ensure it is recognized as
a system-managed PIP that should have its tags updated according to service
annotations.

Also adapted pointer utilities to use pointer.String() instead of ptr.To()
to match the release-1.30 branch conventions.

* fix remaining DNS label test failures for release-1.30

Fixed all remaining DNS label test cases by adding service tags to existing PIPs:
- shall_update_existed_PIP's_dns_label
- shall_update_existed_PIP's_dns_label_for_IPv6 (both variants)
- shall_update_existed_PIP's_dns_label_for_IPv4

After the cherry-picked changes, PIPs without service tags are treated as
user-assigned PIPs and don't have their tags updated by the system. Added
consts.ServiceTagKey to existing PIPs in test data to ensure they are
recognized as system-managed PIPs.

Updated both the existing PIP data and expected results to include the
appropriate service tags, using pointer.String() for release-1.30 compatibility.

Run Details

17 of 17 new or added lines in 1 file covered. (100.0%)

28 existing lines in 1 file now uncovered.

18668 of 24550 relevant lines covered (76.04%)

684.85 hits per line