openconfig / gnoi / 17461322445
0%
main: 0%

LAST BUILD BRANCH: dependabot/go_modules/google.golang.org/grpc-1.78.0
DEFAULT BRANCH: main
Ran
Jobs 1
Files 36
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 0.0%. Remained the same
17461322445

Pull #302

github

brianneville 
gnoi/os: make package_size required.

If the package_size field is unspecified, then the target will proceed
without knowing how large the incoming image is.
This can lead to the target returning an error mid-RPC
if it runs out of disk space to store the incoming image.

To handle this the target is left with two options. Either it must:
 1. assume some default size of the image
 2. not free-up any space for the incoming image

If the target does 1 then the assumed image size may be less
than the actual image (which would cause the target to not
free up enough space) OR the assumed image size may be
larger than the actual image (which may cause the target
to free up excess space, possibly deleting images needlessly).

If the target does 2 then the RPC will fail if there is not
enough space, irrespective of if there were unused images,
and someone would need to manually clean up the unused
images from the target before running the RPC again.

In both cases, we could still fail the RPC if we don't
have enough space.

We should therefore make this package_size field required, so that:
- the target can fail gracefully if the incoming package is too large
 rather than mid-way through the RPC.
- the target can free-up space without needing the network operator
 to ever manually clean up images.
Pull Request #302: gnoi/os: make package_size required.

0 of 12442 relevant lines covered (0.0%)

0.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 17461322445.1 36
0.0
 GitHub Action Run
Source Files on build 17461322445