17451996512
80%

Ran 04 Sep 2025 03:02AM UTC

Jobs 1

Files 34

Run time 1min

Badge

Embed ▾

Committed 03 Sep 2025 09:17AM UTC coverage: 80.368%. Remained the same

Build # 17451996512

Build Type

push

github

Committed by

web-flow

Commit Message

rrd: Fix absolute rate calculations (#6646)

Absolute metric should work as follows:

    Timestamp    = 300, 600, 900, 1200
    Step         = 300 seconds
    ABSOLUTE DS  =    1,  2,   3,    4

But they do not seem to have ever worked correctly - they were
previously divided by the interval but incorrectly handled NaNs,
resulting in wrong behaviour. Then the refactoring (including 73ca3cc
("CA-404597: rrd - Pass Gauge and Absolute data source values as-is"))
broke them further.

Divide absolute metrics by the interval in process_ds_value. Fix the
unit test to expect the right behaviour - it passes with this fix.

---

This means absolute metrics are now correctly calculated as unit/s,
changing the behaviour in
https://github.com/xapi-project/xen-api/pull/6640

I am not 100% sure this fix goes all the way either - unit tests should
cover expected values in RRAs as well, and the logic is still really
confusing to me.

Run Details

3496 of 4350 relevant lines covered (80.37%)

0.8 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	python3.11 - 17451996512.1	04 Sep 2025 03:02AM UTC	34	80.37	GitHub Action Run

xapi-project / xen-api / 17451996512
80%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 17451996512

xapi-project / xen-api / 17451996512 80%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 17451996512

xapi-project / xen-api / 17451996512
80%

README BADGES
x