skeema / skeema / 17446769165

92%

Build Type

push

github

Committed by evanelias

Commit Message

tests: several improvements to integration test framework

This commit includes multiple refactors to Skeema's integration testing
framework, improving test execution speed, as well as reducing common
boilerplate in test functions.

Previously, tests executed any setup SQL statements by using `docker exec` to
invoke the `mysql` or `mariadb` client, inside Dockerized database server test
containers. Unfortunately `docker exec` has nontrivial overhead, and invoking
it too frequently seems to cause random network instability in recent versions
of Docker Desktop for Mac. This commit switches to use of Skeema's SQL
statement handling logic on a reusable connection pool, solving these issues.

Connection reuse is also now enabled for integration tests on Skeema commands.
Previously, connection pools were intentionally closed prior to each subtest,
intending to prevent any session state leaks between subtests. However, this
was unnecessary since no Skeema commands ever leak session state mutations
(each set of session variables gets a distinct conn pool), and very few tests
need to modify session state separately; those tests have been modified here
to either achieve their goals without session state mutation, or by
intentionally closing connection pools if needed otherwise.

The interface of the integration testing framework has been updated to supply
*testing.T values to methods, instead of returning error values. This reduces
error-checking boilerplate: methods can just fatal the test if something goes
amiss during test setup or cleanup.

Similarly, several Docker-related test helper methods now accept a *testing.T
value, and fatal the test if something went wrong, instead of returning an
error value. The new method signatures also more clearly indicate that these
methods are only for use in tests. They have been moved from docker.go to
testing.go accordingly.

Run Details

64 of 88 new or added lines in 2 files covered. (72.73%)

7 existing lines in 3 files now uncovered.

10817 of 11635 relevant lines covered (92.97%)

1.11 hits per line