Qiskit / qiskit / 17415711163

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add `QuantumCircuit.ensure_physical` (#14779)

* Add `QuantumCircuit.ensure_physical`

This is similar but stronger to `DAGCircuit::make_physical`.  Since
`QuantumCircuit` also has layout information available, this method
safely handles this, and the case that the circuit has already been made
physical.

The new documentation in the circuit module and the `QuantumCircuit`
class is intended to help, since this is a common point of confusion
among both users and developers; the documentation isn't supposed to be
a strong personal endorsement of the current situation, just an explicit
statement of what the current system _is_.

This commit was motivated by ad-hoc attempts to do this, such as in
`QuantumCircuit._from_circuit_data(add_regs=True)` (which can be updated
to use this in a follow-up).

* Remove incorrect comment

* Simplify typing of `CircuitData::make_physical`

Run Details

55 of 62 new or added lines in 2 files covered. (88.71%)

9 existing lines in 2 files now uncovered.

91374 of 103384 relevant lines covered (88.38%)

480648.1 hits per line