kubernetes-sigs / external-dns / 17373679665

79%

push

github

fix(txt-registry): skip creation of already-existing TXT records (#4914) (#5459)

* fix(txt-registry): skip creation of already-existing TXT records (#4914)

* refactor(registry): store existing TXT records temporarily between Records and ApplyChanges

* refactor: apply review suggestion for code cleanup

* test: add coverage for recreating A/CNAME records when TXT exists

* refactor: extract generateTXTRecordWithFilter to avoid redundant filtering

* test: add comprehensive test cases and isolate test data for t.Parallel

* docs: clarify comment for isNotManaged to reflect actual behavior

* fix: apply SetIdentifier before filtering TXT records, add regression test

* chore: fix lint warnings

* refactor: use key struct instead of concatenated string for map keys to reduce memory usage

* fix txt_test.go

* fix txt_test.go dependency

* refactor(registry/txt): rename to isAbsent

34 of 34 new or added lines in 1 file covered. (100.0%)

15345 of 19817 relevant lines covered (77.43%)

732.69 hits per line