kubernetes-sigs / cloud-provider-azure / 17373151635

71%

master: 75%

push

github

[release-1.31] fix: Do not return early when pip.publicIPAddress is empty when check… (#9387)

* fix: Do not return early when pip.publicIPAddress is empty when checking the ownership

* fix TestEnsurePublicIPExistsCommon unit test failures

Fixed failing test cases by adding service tags to existing PIPs in test data.
Due to the cherry-picked changes, PIPs without service tags are now treated
as user-assigned PIPs and don't have their tags updated by the system.
Added consts.ServiceTagKey to existing PIPs in tests to ensure they are
recognized as system-managed PIPs that should have their tags updated
according to service annotations.

Fixed the following test cases:
- shall_update_pip_tags_if_there_is_any_change
- shall_update_existed_PIP's_dns_label
- shall_update_existed_PIP's_dns_label_for_IPv6 (both variants)
- shall_update_existed_PIP's_dns_label_for_IPv4

17 of 17 new or added lines in 1 file covered. (100.0%)

18291 of 25838 relevant lines covered (70.79%)

649.53 hits per line