Azure / karpenter-provider-azure / 17334375085

94%

push

github

chore(logging): Add metrics for VM create, and metrics interface (#1129)

* save initial start

* feat: implement flexible metrics system with typed log values

- Add generic Metric struct that accepts variadic MetricValue parameters
- Create reusable value types that know their own logging keys
- Implement wrapper types for pointer values with clear documentation
- Replace hardcoded VM creation logging with new metric system
- Separate concerns: logmetrics.go for metric logic, values.go for value types
- Maintain type safety while providing consistent usage syntax

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: simplify metrics with centralized MetricValue type

- Replace individual typed structs with single MetricValue type
- Make logging keys highly visible in constructor functions
- Use Key() and Value() methods instead of ToKeyValuePair()
- Leverage ValuesToKeyValuePairs helper in logmetrics code
- Rename package from logvalues to metricvalues for clarity
- Remove unnecessary interfaces and wrapper types

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat: add error handling to VM creation metrics

- Add Error() constructor function with visible "error" key
- Add VMCreateSyncFailureMetric and VMCreateAsyncFailureMetric
- Include error details in failure metrics for better debugging
- Refactor to use getBaseVMCreateMetrics helper function
- Emit error metrics for both sync and async VM creation failures

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Update pkg/providers/instance/instance.go

Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>

* address PR comments

* refactor: rename MetricValue to LogValue and move to logging package

- Rename MetricValue to LogValue for better semantic clarity
- Move from pkg/metrics/metricvalues to pkg/lo... (continued)

32 of 32 new or added lines in 3 files covered. (100.0%)

56187 of 58860 relevant lines covered (95.46%)

0.96 hits per line