Qiskit / qiskit / 17330105778

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add angle bound support to target constraints (#14406)

* Add angle bound support to target constraints

This commit adds a new capability to the target for representing angle
bounds on a gate in the target and a transpiler pass to enforce the
bounds are respected. To enable this functionality it requires that the
target constructor provides a function to do the angle wrapping/folding
so that the transpiler knows how to do the transformation of arbitrary
gate appropriately. Since the transpiler can't make any assumption about
the bounds or the angles in use, or the gates that will have bounds
applied. So coming up with a general transpiler pass is not possible,
however a user providing the conversion function when applying a bound
makes it possible for the preset pass maangers to reason about gates
with angle bounds and work with them.

This new feature is strictly additive to the Target which keeps it
backwards compatible. It does mean that for existing workflows a user
will need to opt-in to checking the angle bounds.

Fixes #13784

* Fix lint

* Add missing pickle of angle bounds

* Fix fold rzz function and fix failing test

* Add in bounds angle to workflow test

* Missing imports from release note example

* Handle no-target in translation generation

* Fix release note example

* Fix gitignore

* Pivot to standalone registry

This commit pivots the user interface to the wrapping callbacks. Instead
of putting it all in the target this adds a separate data structure
analgous to the equivalence library for the basis translator but for
WrapAngles. This makes the target solely concerned with the QPU
constraints (which is it's purpose) and the backend provider is
responsible for populating the global registry instance to make the pass
work.

* Change default on check_angle_bounds param

* Rename gate_has_angle_bound -> gate_has_angle_bounds

* Fix lint

* Remove unsound PyCapsule usage

Returning a PyCapsule of the function pointer from Rust to pickl... (continued)

Run Details

211 of 291 new or added lines in 13 files covered. (72.51%)

33 existing lines in 4 files now uncovered.

91269 of 103296 relevant lines covered (88.36%)

480443.65 hits per line