Qiskit / qiskit / 17293270440

88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix: Memory leakage in `QkCountOps` creation. (#14930)

* Fix: Memory leakage in `QkCountOps` creation.
The following commits attempt to fix some memoery issues that the struct `QkOpCounts`. The `qk_opcounts_free` method would segfault if an empty object was passed. The function now checks whether the passed option includes a null pointer or an empty instance. The commits also change how the `data` attribute is generated without using `std::mem::forget`, but instead collection the `OpCount` vec into a boxed_slice and consuming it into a `Box`. Inspired by what was done for #14884.

* Docs: Add release note.

* Fix: Ironic memory leakage

* Fix c opcounts free suggestion (#7)

* Rename to _clear, free name

* rm dangling file

* use pointers

* ... forgot to register test

* fix `size_t`

* Fix: Missed some renaming

* add note on clearing opscount

* be explicit about loading Box<[OpCount]>

* fix merge artifact

* Apply suggestions from code review

Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

* goto

* happy miri happy life

* Fix merge artifacts

---------

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
Co-authored-by: Eli Arbel <46826214+eliarbel@users.noreply.github.com>

Run Details

23 of 23 new or added lines in 1 file covered. (100.0%)

16 existing lines in 3 files now uncovered.

90341 of 102188 relevant lines covered (88.41%)

486169.53 hits per line