kubevirt / hyperconverged-cluster-operator / 17264181252

76%

Build Type

push

github

Committed by web-flow

Commit Message

Improve the performance of the HyperConverged CR deletion + some chores (#3730)

* Improve the performance of the HyperConverged CR

When the HyperConverged CR is deleted, the current behavior is to
remove the KubeVirt, CDI, CNAO, SSP, and the AAQ CRs (with some
additional resources and CRs).

The deletion itself takes a lot of time. By looking at the SSP operator
code, it appears that it is trying to access several CDI and KubeVirt
CRs, like VirtualMachines or DataImportCron, and that these
operations are failed, because the relevant CRDs were already removed
by the virt operator and the cdi operator, when the KubeVirt and the CDI
CRs were removed.

That delays the removal of the SSP CR for a few minutes. Eventually,
the SSP CR is deleted, and then the HyperConverged is deleted too,
but it takes long time.

This PR changes the order of the resource deletions. It removes the
KubeVirt and the CDI CRs, only after all the other resources and CRs
are successfully removed.

The result is much faster deletion of the HyperConverged CR.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Get rid of the `JustBeforeComplete` method

The HCOOperandHooks interface defines the `JustBeforeComplete` method to
be called after a specific operand was successfully ensured.

After a few years, it is very clear that we never used this hook method,
except for the SSP handler. Any other operand handler must implement
this method to satisfy the interface, but has no implementation. This
is just a redundant code that we don't need, and make the code a bit more
complex for no good reason, make it harder to read and understand, to
add new handlers and so on. Also, in general, we prefer interfaces to be
as small as possible.

This PR removes the `JustBeforeComplete` method from the HCOOperandHooks
interface, and all the method implementations from all the handlers.

The SSP handler was modified to be a `GenericOperand` wrapper, instead
of just a `GenericOperand` objec... (continued)

Run Details

56 of 58 new or added lines in 7 files covered. (96.55%)

10 existing lines in 1 file now uncovered.

7862 of 10189 relevant lines covered (77.16%)

1.84 hits per line