MITLibraries / marimo-launcher / 17248717173

88%

main: 88%

Build Type

Pull #13

github

Committed by ghukill

Commit Message

Support launching the notebook with a base URL

Why these changes are being introduced:

Based on the interplay of the ALB and the notebook running in an ECS
fargate container, we realized that we would need to launch the notebook on
a particular URL path.

Thankfully, Marimo supports this with a --base-url flag.

How this addresses that need:

* Adds --base-url / NOTEBOOK_BASE_URL configurations to explicitly set a
base url to launch on
* Adds flags + env vars to skip a base URL entirely
* If neither are passed, the default behavior is to construct a base URL
from the repository name + notebook path

Side effects of this change:
* This aligns with the URL patterns that ALB requests will send to the running
notebook.  By passing --repo https://github.com/foo/bar and --path super/notebook.py,
the resulting base URL will be "bar/super/notebook.py" which is precisely
what the ALB will send as requests

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1441

Pull Request Pull Request #13: IN 1441 - support a base URL on notebook launch

Run Details

13 of 14 new or added lines in 1 file covered. (92.86%)

11 existing lines in 1 file now uncovered.

99 of 112 relevant lines covered (88.39%)

0.88 hits per line