Qiskit / qiskit / 17247592556

88%

Build Type

push

github

Committed by web-flow

Commit Message

Bump Faer to latest version and increase MSRV to 1.85 (#14873)

* Bump Faer to latest version and increase MSRV to 1.85

This commit bumps the faer package version used by qiskit to the latest
release 0.22.6 which is up from 0.19.4. We had held back on upgrading
the faer release because more recent versions bumped the MSRV to 1.84
when that was *very* new. Now that we're more time out from that release
we can consider bumping Qiskit MSRV. To enable using the latest faer
version. Additionally, the latest faer version fixes issues identified
with using the older release on Windows.

This commit  opts to raise the MSRV to 1.85 instead of 1.84,
as this will enable us to use Rust Edition 2024 which has some nice
QoL improvements and its worth upgrading too.

Typically we would have held back on bumping the MSRV until 3.0, but it
might be some time before 3.0 is branched and we explicitly do call out
in the version strategy that the minimum supported Rust version isn't
part of the backwards compatibility guarantees around Qiskit [1], so we
are able to bump it if there is a need to. The need to fix the issues
when running on Windows also requires us to upgrade our version of faer
now instead of later.

[1] https://quantum.cloud.ibm.com/docs/en/open-source/qiskit-sdk-version-strategy

* Downgrade to faer 0.21

Faer 0.22 has bugs that prevent it from building on x86_64 macOS which
prevents us from using it. However the 0.21 release doesn't seem to have
these issues which should also hopefully fix the issue on windows. This
commit downgrades to the 0.21 release instead of 0.22 to see if it works
on both platforms.

* Try an earlier nightly for miri

* Lower tolerance for quantum info tests under miri

Miri intentionally has reduced floating point precision on newer
versions of the rust compiler. Since we have to bump the nightly version
we use for the miri tests because the version we were previously using
is older than the new MSRV. This is causing some quantu... (continued)

Run Details

36 of 36 new or added lines in 5 files covered. (100.0%)

4 existing lines in 2 files now uncovered.

90136 of 101941 relevant lines covered (88.42%)

487517.04 hits per line