thumbor / thumbor-aws / 17239886813

90%

push

github

fix: Move the `AWS_NORMALIZER` config to top-level configuration list (#316)

The `AWS_NORMALIZER` configuration is used for both the storage and result
storage modules, but there's no requirement to use the storage module if you
only need the result storage module. In that case, you might have the storage
module configured with:

```
STORAGE = "thumbor.storages.no_storage"
```

In that case, the `thumbor_aws.storage` file is never loaded, which means the
`AWS_NORMALIZER` configuration never gets defined, which in turn means any
requests for the result storage module which tries to call `normalize_path`
will fail with an error like this:

```
2025-08-26 08:08:38 thumbor:ERROR [BaseHander.execute_image_operations] AWS_NORMALIZER
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/thumbor/handlers/__init__.py", line 145, in execute_image_operations
    result = await self.context.modules.result_storage.get()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/thumbor_aws/result_storage.py", line 168, in get
    file_abspath = normalize_path(self.context, self.prefix, path)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/thumbor_aws/utils.py", line 9, in normalize_path
    new_path = context.config.AWS_NORMALIZER(path)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/derpconf/config.py", line 225, in __getattr__
    raise AttributeError(name)
AttributeError: AWS_NORMALIZER
```

This fixes that by moving the configuration setting to the top-level config
file to make sure it's always defined, regardless of if `thumbor_aws.storage`
is used or not.

2 of 2 new or added lines in 1 file covered. (100.0%)

320 of 357 relevant lines covered (89.64%)

4.47 hits per line