thumbor / thumbor-aws / 17239886813
90%

DEFAULT BRANCH: main
Ran
Jobs 5
Files 6
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.636%. Remained the same
17239886813

push

github

web-flow 
fix: Move the `AWS_NORMALIZER` config to top-level configuration list (#316)

The `AWS_NORMALIZER` configuration is used for both the storage and result
storage modules, but there's no requirement to use the storage module if you
only need the result storage module. In that case, you might have the storage
module configured with:

```
STORAGE = "thumbor.storages.no_storage"
```

In that case, the `thumbor_aws.storage` file is never loaded, which means the
`AWS_NORMALIZER` configuration never gets defined, which in turn means any
requests for the result storage module which tries to call `normalize_path`
will fail with an error like this:

```
2025-08-26 08:08:38 thumbor:ERROR [BaseHander.execute_image_operations] AWS_NORMALIZER
Traceback (most recent call last):
  File "/usr/local/lib/python3.12/site-packages/thumbor/handlers/__init__.py", line 145, in execute_image_operations
    result = await self.context.modules.result_storage.get()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/thumbor_aws/result_storage.py", line 168, in get
    file_abspath = normalize_path(self.context, self.prefix, path)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/thumbor_aws/utils.py", line 9, in normalize_path
    new_path = context.config.AWS_NORMALIZER(path)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/derpconf/config.py", line 225, in __getattr__
    raise AttributeError(name)
AttributeError: AWS_NORMALIZER
```

This fixes that by moving the configuration setting to the top-level config
file to make sure it's always defined, regardless of if `thumbor_aws.storage`
is used or not.

320 of 357 relevant lines covered (89.64%)

4.47 hits per line

Coverage Regressions

Lines Coverage ∆ File
5
93.9
 -0.15% thumbor_aws/storage.py
2
90.0
 1.11% thumbor_aws/config.py
Jobs
ID Job ID Ran Files Coverage
1 run-3.9 - 17239886813.1 6
89.36
 GitHub Action Run
2 run-3.10 - 17239886813.2 6
89.64
 GitHub Action Run
3 run-3.11 - 17239886813.3 6
89.64
 GitHub Action Run
4 run-3.13 - 17239886813.4 6
89.36
 GitHub Action Run
5 run-3.12 - 17239886813.5 6
89.36
 GitHub Action Run
Source Files on build 17239886813