ovn-kubernetes / ovn-kubernetes / 17237736047

56%

Build Type

push

github

Committed by jcaamano

Commit Message

Fix getHostNamespaceAddressesForNode error wrapping

Incorrect wrapping of errors in getHostNamespaceAddressesForNode
prevented callers to assert the type of error returned. In this specific
case the caller delIPFromHostNetworkNamespaceAddrSet could not appropriately
check that the error returned was AnnotationNotSetError and was failing
a deletion flow that should be noop instead.

This was triggered by [1] changes that cause the deletion flow to depend on
annotations set by different controllers instead of annotations set
atomically by a single controller, making it possible that some
annotations were set but not others and opening up a new error handling
flow that wasn't possible before. The scenario is a node that is added
and deleted quickly enough for some controller in cluster manager to be
able to annotate the node and some not.

[1] https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5396

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>

Run Details

7 of 9 new or added lines in 1 file covered. (77.78%)

20 existing lines in 4 files now uncovered.

38665 of 70738 relevant lines covered (54.66%)

441.55 hits per line