Qiskit / qiskit / 17219028946

88%

Build Type

push

github

Committed by web-flow

Commit Message

Make `BasisTranslator` rust-native. (#14659)

* TBD

* TBD 0

* TBD: Moved most of the operations in compose_transform to be rust native.

* Fix: Revert any removals related to `ParameterExpression`.
- We cannot get away with not using `ParameterExpression` to create unique parameters. Until a better alternative comes around, we should stick to using it.

* Fix: Remove `LazyLock`.
- As of 1.79, `LazyLock` was not yet made stable, these commits remove `LazyLock` in favor of `OnceLock`.

* Fix: Remove most pytokens by avoiding building a dict.
- Skipping the dict builds and using `Python::with_gil` avoids using python tokens when not necessary during the `replace_node` method in `run_basis_translator`.
    - The dictionary in question was only really needed when an instance of `ParameterExpression` is present on the gate. So it is optionally built if an instance of Parameter expression is found.
- The last remaining usage of py tokens exists during `compose_transforms` which still builds a parameter vector.

* Filter to only parameter expression when building parameter_map.
- In `replace_node` we will first filter out `ParameterExpression` keys in the parameter map. If the collection comes out empty, we don't build the mapping.

* Fix: Use rust native parameters.

* Fix: Re-add "fixedbitset"

* Fix: Convert to `Param::Float` if a real value is obtained

* Fix: Second rebase

* Add: Leverage use of rust-native `substitute_node_with_py`.

* Fix: Implement native errors for `BasisTranslator`.
- Use `Matrix::Identity` based on the provided matrices.
- Add trait `ToPyErr` that ensures any new error is converted to its respective Python counterpart.
- Remove indexing from `ParameterExpression` creation in `compose_transforms`.
- Remove incorrect coercion into value from `replace_node`.

* Add: global operation extraction from Rust.
- Modify `Target::get_non_global_operation_names` to not return an option.

* Fix: Remove unused import in python `BasisTranslato... (continued)

Run Details

344 of 469 new or added lines in 5 files covered. (73.35%)

24 existing lines in 5 files now uncovered.

89888 of 101716 relevant lines covered (88.37%)

488288.24 hits per line