• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

enbility / spine-go / 17159964497
94%

Build:
DEFAULT BRANCH: dev
Ran 22 Aug 2025 03:57PM UTC
Jobs 1
Files 61
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

22 Aug 2025 03:56PM UTC coverage: 94.0% (-0.03%) from 94.034%
17159964497

push

github

web-flow
🐛 fix: add cmdFunction parameter to FilterType.Data() for partial filter handling (#67)

This critical fix addresses type confusion vulnerabilities and improves
SPINE protocol compliance by properly handling partial filters without
selectors.

## Changes:
- **BREAKING**: FilterType.Data() now requires cmdFunction parameter
- Add cmdFunction parameter to all UpdateList implementations (30+
files)
- Fix critical bug where UpdateList returned slices instead of complete
structs
- Add validation helpers for cmd.Function consistency checking
- Add comprehensive test coverage for function mismatches and edge cases

## Security Improvements:
- Prevent type confusion attacks where cmd.Function doesn't match filter
functions
- Proper fallback to cmdFunction for partial filters without selectors
- Validation methods to detect and report function inconsistencies

## Bug Fixes:
- Fix panic in TestLoadControlLimitListDataType_Update (line 126)
- Correct partial filter logic that incorrectly used selector path when
no selectors present
- Return complete structs from UpdateList, not just data slices
- Fix incorrect field names in multiple *_additions.go files

## Spec Compliance:
- Properly implements SPINE Table 6/7 requirements for partial updates
- Handles "copy to all" pattern when identifiers are missing
- Supports valid partial filters without selectors (meaning "all
fields")

## Testing:
- Add cmd_function_filter_mismatch_test.go for security validation
- Add cmd_validation_additions_test.go for consistency checks
- Add device_local_validation_test.go for local device validation
- Update all existing tests to use new cmdFunction parameter

BREAKING CHANGE: FilterType.Data() signature changed to require
cmdFunction parameter. All code using FilterType.Data() must be updated
to pass the cmdFunction.

310 of 322 new or added lines in 32 files covered. (96.27%)

5609 of 5967 relevant lines covered (94.0%)

28518.13 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
90.44
0.0% model/nodemanagement_additions.go
10
88.24
model/cmd_validation_additions.go
Jobs
ID Job ID Ran Files Coverage
1 17159964497.1 22 Aug 2025 03:57PM UTC 61
94.0
GitHub Action Run
Source Files on build 17159964497
  • Tree
  • List 61
  • Changed 31
  • Source Changed 31
  • Coverage Changed 4
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #17159964497
  • 08a28fe4 on github
  • Prev Build on dev (#17122433974)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc