Ouranosinc / miranda / 17135863835

18%

Build Type

push

github

Committed by web-flow

Commit Message

No longer initialize logging within library (#264)

### What kind of change does this PR introduce?

* Adjusts logging so that submodules do not initialize the logging
configuration.
* Sets all modules using logging to log relative to the `miranda`
library (never `root`).
* Adds a missing function needed for a submodule that was removed in an
earlier PR.

### Does this PR introduce a breaking change?

Yes. If you rely on the logging messages, you need to initialize the
logger in your scripts as follows:
```python
import logging.config

from miranda.scripting import LOGGING_CONFIG

logging.config.dictConfig(LOGGING_CONFIG)
```

There might be a much easier way to get this up and running, but with
these changes, we no longer need to worry about submodules setting this
accidentally.

### Other information:

There was a missing function (`group_by_length`) that was entirely
missing. This wasn't raising errors, as the module that relied on it
wasn't being loaded on import.

Run Details

48 of 231 new or added lines in 28 files covered. (20.78%)

3 existing lines in 3 files now uncovered.

1199 of 6403 relevant lines covered (18.73%)

1.3 hits per line