pashagolub / pgxmock / 16851312510

94%

master: 94%

Build Type

Pull #241

github

Committed by theory

Commit Message

Teach Rows.CloseError to set the error

`Rows.Close` doesn't return an error, so up to now `Rows.CloseError` was
a no-op. However, pgx's `Rows.Err` can return an error after `Rows.Next`
returns false, or after `Rows.Close` has been called.

Add `rowSets.close()` to mark the current rows closed, jump the record
number to the last row, and to set the close error for that row. Then
have `rowSets.Close()` call it and `rowSets.Next()` call it once it has
processed the last row. These changes cause both `Rows.Err` and
`Rows.Scan` to return the close error once it has been set. Add tests
for this behavior.

While at it, have `Rows.Scan` return immediately when the rows have been
closed, rather than carrying out all the scanning.

Add tests to test these behaviors.

Fixes #238.

Authors:
*   asayapini <asayapini@ozon.ru>
*   David E. Wheeler <david@justatheory.com>

Pull Request Pull Request #241: Teach Rows.CloseError to set the error

Run Details

15 of 15 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

827 of 880 relevant lines covered (93.98%)

1.09 hits per line