babelfish-for-postgresql / babelfish_extensions / 17047974152

77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix view repair crash caused by comments in SQL definition (#4026)

The view repair mechanism was crashing when processing view definitions containing comments at start of the SQL definition.
This happens during the parse_analyze_fixedparams call in repair_broken_view_recursive, specifically in the pre_transform_target_entry function where a memory access violation occurs.

This fix:
Uses ANTLR-processed SQL text for parsing instead of raw view definition (stmt_sql->sqlstmt->query), where stmt_sql is result of ANTLR parser for the original viewdef

Issues Resolved: None
Signed-off-by: Rahul Parande <rparande@amazon.com>

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

50030 of 65748 relevant lines covered (76.09%)

377387.92 hits per line