17043903681
85%
master: 85%

Ran 18 Aug 2025 02:52PM UTC

Jobs 0

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 17043903681

Build Type

push

github

Committed by

web-flow

Commit Message

DOLfYN/RDI: Set  `fs` to NaN when typical calculation methods yield error (#408) (#409)

## Summary

Fix #408: ZeroDivisionError when reading RDI burst mode data files where
`sec_between_ping_groups=0` causes division by zero in sampling
frequency calculation.

## Changes

- Added check for `sec_between_ping_groups == 0` before calculation of
`fs`.

  - When true, set `fs` to `NaN` with descriptive warning.

- Added test using `unittest.mock.patch` to verify fix behavior with
burst mode configuration.

- Fixed pytest-asyncio deprecation warning in test configuration.

## Details

Per #408 RDI instruments in continuous burst mode set
`sec_between_ping_groups=0` for maximum ping rate, causing
ZeroDivisionError in:

```python
cfg["fs"] = 1 / (cfg["sec_between_ping_groups"] * cfg["pings_per_ensemble"])
```

The fix detects this condition and sets fs=NaN since burst mode
operation with variable timing prevents reliable sampling rate
determination using standard methods.

## Testing

Patch RDIReader.finalize to set `sec_between_ping_groups` to `0` and
verify the fix prevents the `ZeroDivisionError`, sets `fs` to `np.nan`
and warns the user.

Run Details

Source Files on build 17043903681

Detailed source file information is not available for this build.

MHKiT-Software / MHKiT-Python / 17043903681
85%
master: 85%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 17043903681

MHKiT-Software / MHKiT-Python / 17043903681 85% master: 85%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 17043903681

MHKiT-Software / MHKiT-Python / 17043903681
85%
master: 85%

README BADGES
x