kubevirt / hyperconverged-cluster-operator / 17041982073

76%

push

github

Fix the Webhook's metrics endpoint (#3708)

* Move the APIServer controller into sub-pkg

The APIServer controller is currenlty the only webhook controller.
In order to later add another webhook controller, move the webhook
controller files into the new
"controllers/webhooks/apiserver-controller" sub-package.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Expose several functions and consts in the alerts pkg

In order to share code with the new WH bearer token reconciler, expose
several functions and consts.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* Add new Bearer token controller to the WH

The metrics endpoint in the operator and the webhook are protected with
a bearer token. However, the creation of the related resources are only
done for the operator. That makes the webhook metrics endpoint non-accessible.

This commit adds a controller to the webhook, to ceate and reconcile the
missing resources.

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* add e2e test to validate the WH bearer token

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

* fix bug: remove 3 left over services after uninstalling HCO

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

---------

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>

270 of 321 new or added lines in 13 files covered. (84.11%)

7803 of 10086 relevant lines covered (77.36%)

1.86 hits per line