gluesql / gluesql / 17022570548

99%

Build Type

push

github

Committed by web-flow

Commit Message

Remove ast::Statement ToSql trait implementation (#1746)

GlueSQL's AST includes some partial SQL structural information and execution plans.

ToSql assumes that our AST can be converted to SQL but it is actually not.
e.g.
non-clustered index, primary key, hash join, ...

This kind of partial support can make us hard to maintain the codes.

This PR starts removing ToSql impl from our AST nodes by removing ToSql impl in ast::Statement.
If there is still need of restoring SQL from AST, then we can use it from sqlparser-rs' AST, not gluesql's.

Coverage Stats

25 of 25 new or added lines in 1 file covered. (100.0%)

19 existing lines in 3 files now uncovered.

36537 of 37376 relevant lines covered (97.76%)

64562.66 hits per line