sapcc / limes / 16993760738

80%

master: 80%

Build Type

Pull #765

github

Committed by majewsky

Commit Message

rename project_commitments.{state => status} and {'active' => 'confirmed'}

This removes the original db.ProjectCommitmentState enum in favor of the
newer liquid.CommitmentStatus enum. In the commitment API, this only
removes a lot of manual type casting because liquid.CommitmentStatus was
already used there throughout.

The only place that still uses the old state enum is the "state" label
of the limes_project_committed_per_az metric. We will clean this up
later with the v2 data metrics.

I also took the opportunity to replace literal mentions of status values
with fmt.Sprintf() in some SQL queries, though admittedly not in all of
them yet.

Pull Request Pull Request #765: cleanup old types in project_commitments table

Run Details

120 of 125 new or added lines in 12 files covered. (96.0%)

9 existing lines in 2 files now uncovered.

7364 of 9233 relevant lines covered (79.76%)

57.46 hits per line