|
Ran
|
Jobs
1
|
Files
518
|
Run time
2min
|
Badge
README BADGES
|
push
github
box: fix key corruption when pagination by tuple is used Function `iterator_pos_set` works completely incorrectly when tuple is passed to the option `after`. Firstly, before extracting position, we call `ibuf:consume()` for the memory allocated before position (this method is actually ASAN poisoning) - that's not correct since consumed memory contains query key that will be used later. Let's remove this call. Secondly, new allocation on ibuf can lead to its reallocation, so pointers to old allocations can be invalidated. Let's set the pointers to the key after all allocations are done, just like in `index:quantile()`. What's about performance, `perf/lua/box_select.lua` shows no degradation. Closes #11221 Closes #11648 NO_DOC=bugfix (cherry picked from commit 7426f5912)
70253 of 124087 branches covered (56.62%)
103270 of 117960 relevant lines covered (87.55%)
1631440.99 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
93.66 |
-0.14% | src/box/txn_limbo.c |
| 1 |
92.51 |
0.05% | src/box/vinyl.c |
| 1 |
95.21 |
-0.53% | src/box/vy_range.c |
| 1 |
91.21 |
0.2% | src/box/vy_scheduler.c |
| 1 |
87.5 |
-1.59% | src/box/xlog.h |
| 1 |
97.46 |
0.1% | src/lib/msgpuck/msgpuck.h |
| 2 |
93.95 |
-0.5% | src/box/vy_write_iterator.c |
| 2 |
84.27 |
-0.04% | src/box/xlog.c |
| 3 |
22.64 |
-0.06% | src/lib/uri/uri_parser.c |
| 4 |
93.31 |
-1.27% | src/lib/swim/swim_io.c |
| 5 |
91.17 |
0.41% | src/box/box.cc |
| 5 |
87.43 |
-0.05% | src/box/vy_run.c |
| 5 |
94.25 |
-0.98% | src/box/xrow_update_field.c |
| 9 |
88.14 |
-7.63% | src/box/vy_regulator.c |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 16992302163.1 | 518 |
87.55 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|