tarantool / tarantool / 16992254682

88%

push

github

box: fix key corruption when pagination by tuple is used

Function `iterator_pos_set` works completely incorrectly when tuple
is passed to the option `after`.

Firstly, before extracting position, we call `ibuf:consume()` for
the memory allocated before position (this method is actually ASAN
poisoning) - that's not correct since consumed memory contains query key
that will be used later. Let's remove this call.

Secondly, new allocation on ibuf can lead to its reallocation, so
pointers to old allocations can be invalidated. Let's set the pointers
to the key after all allocations are done, just like in `index:quantile()`.

What's about performance, `perf/lua/box_select.lua` shows no degradation.

Closes #11221
Closes #11648

NO_DOC=bugfix

70864 of 124753 branches covered (56.8%)

104072 of 118816 relevant lines covered (87.59%)

1370745.9 hits per line