mongodb-js / devtools-shared / 16946613464

78%

Build Type

push

github

Committed by web-flow

Commit Message

fix(devtools-connect): fix TLS error fallback mechanism MONGOSH-2488 (#566)

Restructure our proxy integration logic to:

- Avoid modifying the OIDC options – previously we were assigning to
  `clientOptions.oidc`, which meant that the `fetch` function created
  to read the system certificates was also used for the non-system-cert
  `connect()` call, breaking our fallback mechanism
- Add a test that verifies that the fallback mechanism works both for
  TLS driver connections and HTTPS OIDC calls.
- Deduplicate the logic for adding CA options to the `DevtoolsProxyOptions`
  instances.
- Share log info from the OIDC agent instance, if a new one has been
  created.
- Make sure that TLS errors passed through node-fetch are actually
  picked up by our "nested error" detection logic (they have a different
  `toStringTag` defined than regular `Error` instances).

Run Details

1510 of 2359 branches covered (64.01%)

Branch coverage included in aggregate %.

18 of 30 new or added lines in 4 files covered. (60.0%)

35 existing lines in 2 files now uncovered.

3267 of 4200 relevant lines covered (77.79%)

594.75 hits per line