payjoin / rust-payjoin / 16942107516

83%

Build Type

push

github

Committed by web-flow

Commit Message

Decapsulate v1 provisional and payjoin typestate from v2 typestate (#938)

We currently represent a failure to finalize a Payjoin proposal using
the `ReplayableError(ImplementationError)` variant. While this is
appropriate for a v1 Payjoin receiver, it misrepresents the expected
behavior for a v2 receiver. In v2, encountering an implementation error
is considered a transient failure. i.e the receiver should retry the
session rather than respond to the sender and terminate it.

This misclassification stems from the current v2 -> v1 type hierarchy,
which forces the v2 receiver to adopt `ReplayableError`, when a
more suitable variant exists. In reality, the v2 receiver only requires
a shared abstraction (`PsbtContext`) to finalize the PSBT and construct
a
payjoin proposal. It does not need to embed or depend on the v1
receiver’s typestates.

This PR introduces `PsbtContext` as a common abstraction for
proposal finalization and decouples the `ProvisionalProposal` and
`PayjoinProposal` typestates from the v1 typestate. Additionally we map
the finalize proposal error to a new SessionError integration error
variant.

Run Details

122 of 129 new or added lines in 5 files covered. (94.57%)

1 existing line in 1 file now uncovered.

7501 of 8732 relevant lines covered (85.9%)

533.68 hits per line