tari-project / tari / 16933396277
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 820
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 54.463% (+0.2%) from 54.254%
16933396277

push

github

web-flow 
feat: add seed peer exclusion to the proactive dialer (#7396)

Description
---
Added seed peer exclusion to proactive dialing when selecting available
candidates from the peer_db.

Motivation and Context
---
Seed peers are known entities; they have been dialled during initial
seed_strap, and a well-connected network should try to learn about and
connect to other peers as well.

How Has This Been Tested?
---
System-level testing.

What process can a PR reviewer use to test or verify this change?
---
Code review.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved connection management by excluding seed peers from proactive
dialing candidates, enhancing network stability and reducing unnecessary
connection attempts and failed dials.

* **Documentation**
* Added a brief doc comment describing how to retrieve the list of seed
peers.

* **Tests**
* Expanded test coverage to validate discovery and syncing behavior when
seed peers are present and when filtering by external addresses.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

41 of 42 new or added lines in 3 files covered. (97.62%)

1673 existing lines in 28 files now uncovered.

76415 of 140305 relevant lines covered (54.46%)

194087.6 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
65.77
 0.81% comms/core/src/connectivity/proactive_dialer.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
93.35
 -0.18% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
75.98
 -0.22% comms/core/src/connection_manager/peer_connection.rs
1
65.77
 0.81% comms/core/src/connectivity/proactive_dialer.rs
1
90.05
 -0.25% comms/core/src/multiplexing/yamux.rs
1
60.35
 0.27% comms/dht/src/connectivity/mod.rs
2
55.75
 0.42% comms/core/src/connectivity/manager.rs
3
0.0
 0.0% base_layer/core/src/chain_storage/lmdb_db/mod.rs
3
28.13
 -9.38% base_layer/core/src/proof_of_work/accumulated_difficulty.rs
3
86.84
 -2.63% base_layer/core/src/proof_of_work/difficulty.rs
5
0.0
 0.0% base_layer/core/src/base_node/comms_interface/error.rs
5
77.92
 -4.69% base_layer/core/src/consensus/chain_strength_comparer.rs
6
55.81
 1.27% base_layer/core/src/blocks/historical_block.rs
6
0.0
 0.0% base_layer/core/src/proof_of_work/error.rs
9
71.79
 0.37% base_layer/core/src/proof_of_work/proof_of_work_algorithm.rs
10
12.12
 -0.19% base_layer/core/src/validation/error.rs
12
0.0
 0.0% base_layer/core/src/base_node/sync/block_sync/synchronizer.rs
22
0.0
 0.0% base_layer/core/src/proto/block.rs
24
0.0
 0.0% base_layer/core/src/base_node/proto/response.rs
30
7.41
 -0.59% base_layer/core/src/base_node/metrics.rs
37
51.41
 1.05% base_layer/core/src/chain_storage/db_transaction.rs
46
86.5
 -1.26% base_layer/core/src/blocks/genesis_block.rs
48
67.73
 -2.32% base_layer/core/src/blocks/accumulated_data.rs
62
92.86
 0.1% base_layer/core/src/consensus/consensus_constants.rs
72
56.41
 0.04% base_layer/core/src/chain_storage/blockchain_database.rs
99
59.08
 -0.51% base_layer/core/src/validation/helpers.rs
107
70.12
 2.45% base_layer/core/src/chain_storage/lmdb_db/lmdb.rs
158
0.0
 0.0% base_layer/core/src/base_node/comms_interface/inbound_handlers.rs
899
55.94
 0.13% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
Jobs
ID Job ID Ran Files Coverage
1 16933396277.1 820
54.46
 GitHub Action Run
Source Files on build 16933396277