MITLibraries / timdex-dataset-api / 16910973457

93%

main: 93%

Build Type

Pull #161

github

Committed by ghukill

Commit Message

First pass at reinstating all tests

Why these changes are being introduced:

During the refactor to use dataset metadata for querying,
we had to temporarily skip tests that tested for dataset
filtering and current records limiting.  With the SQL backed
querying now in place, these tests can be reinstated.

Note that a future commit will likely *add* a couple more
tests for the new, optional 'WHERE' clause functionality.

How this addresses that need:
* No tests are skipped.
* Dataset filtering tests still remain, but the key/value
filters are just handled differently under the hood.
* Tests for current records no longer use
.load(current_records=True) but instead utilize the
DuckDB table via table='current_records' within a
read method.

Side effects of this change:
* None

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-529

Pull Request Pull Request #161: TIMX 529 - read methods utilize SQL + metadata context

Coverage Stats

116 of 130 new or added lines in 4 files covered. (89.23%)

33 existing lines in 4 files now uncovered.

458 of 492 relevant lines covered (93.09%)

0.93 hits per line