vortex-data / vortex / 16906445831

88%

Build Type

push

github

Committed by web-flow

Commit Message

chore: improve vortex-dtype test coverage (#4204)

# Summary of Changes in vortex-dtype

## 1. **DecimalDType Safety Improvements** ✅
- Added `try_new()` fallible constructor that returns `Result`
- Added `MIN_SCALE` constant (-76) validation 
- `new()` now calls `try_new()` internally with panic on error
- Validates precision ≤ MAX_PRECISION (76)
- Validates scale within [MIN_SCALE, MAX_SCALE] range
- Updated all serialization code to use `try_new()`:
  - `arrow.rs`: Arrow type conversions
  - `serde/flatbuffers/mod.rs`: FlatBuffer deserialization  
  - `serde/proto.rs`: Protobuf deserialization

## 2. **StructFields API Enhancement** ✅
- Added `try_without_field()` that returns `Result` for safe field
removal
- Deprecated `without_field()` which panics on invalid index
- Proper bounds checking with descriptive error messages

## 3. **Comprehensive Test Coverage** ✅
### decimal.rs (160 new lines)
- Boundary testing for MAX/MIN precision and scale
- Negative scale validation
- Bit width calculations
- Type conversion tests

### field_mask.rs (219 new lines)  
- All three mask types (All, Prefix, Exact)
- `step_into()` transitions
- `starting_field()` behavior
- Helper functions for test construction
- Removed TODO comment about API improvements

### nullability.rs (67 new lines)
- BitOr operator combinations
- Bool conversions and round-trips
- Chained operations

### serde/flatbuffers/project.rs (172 new lines)
- Field resolution by name
- Field extraction from structs
- Projection and deserialization
- Error cases for missing fields

### serde/proto.rs (249 new lines)
- Round-trip tests for all DType variants
- PType conversions
- FieldPath serialization
- Error cases for invalid data

## 4. **Other Crates Updated** ✅
- `vortex-duckdb`: Uses `DecimalDType::new()` (still safe due to
internal try_new)
- `vortex-python`: Uses `DecimalDType::new()` (still safe)
- Both maintain backwards compatibility

## Summary Statistics
- **Files changed**: 12
- **In... (continued)

Run Details

650 of 655 new or added lines in 12 files covered. (99.24%)

1 existing line in 1 file now uncovered.

55118 of 63323 relevant lines covered (87.04%)

535056.59 hits per line