skeema / skeema / 16894896460

92%

push

github

temp-schema: drop routines with chunking during dirty workspace cleanup

When using workspace=temp-schema, if a dirty workspace schema already exists
for whatever reason (e.g. aborted execution during a previous `skeema`
invocation), previously any routines were dropped using multiple connections.
This was done because DROP PROCEDURE and DROP FUNCTION can only be supplied a
single name at a time, unlike DROP TABLE which accepts multiple at once.

This commit adjusts the logic to instead use chunking via multiStatements:
sending multiple DROP queries in a single round-trip. Single-statement
fallback logic is present if any errors occur, since some proxies do not
support multiStatements, and other proxies provide the ability to disable it.

This is largely being motivated for consistency reasons; that is, all logic
which accepts a drop chunk size option now actually performs chunking. This
particular method is rarely used, as the dirty workspace scenario does not
ordinarily come up. The only other call-path is when the reuse-temp-schema
option is enabled, but that option has been deprecated for years and will be
removed in Skeema v2.

Additionally, this commit moves one query away from using sqlx struct-
scanning. Other queries will be slowly moved off of sqlx over time, with an
eventual low-priority goal of removing the dependency on sqlx completely.

37 of 46 new or added lines in 1 file covered. (80.43%)

10809 of 11628 relevant lines covered (92.96%)

1.11 hits per line