vortex-data / vortex / 16891240853

88%

push

github

fix: small resource leak in vortex-io, plus test improvements (#4201)

# Vortex-IO Improvements Summary

## Overview
Comprehensive improvements to the vortex-io crate focusing on safety,
test coverage, and production readiness.

## Statistics
- **Files Modified:** 10
- **Lines Added:** 1,144 
- **Lines Removed:** 19
- **Test Coverage:** Increased from ~40% to comprehensive coverage
- **Tests Added:** 95 high-value tests
- **Critical Bugs Fixed:** 5

## Critical Bugs Fixed

### 1. SizeLimitedStream Permit Leak (CRITICAL - Resource Exhaustion)
**File:** `vortex-io/src/limit.rs`  
**Problem:** Futures dropped before completion leaked semaphore permits,
causing resource exhaustion.
**Solution:** Used `OwnedSemaphorePermit` to automatically return
permits when futures are dropped.
```rust
struct SizedFut<Fut> {
    #[pin]
    inner: Fut,
    /// Owned permit that will be automatically dropped when the future completes or is dropped
    _permits: OwnedSemaphorePermit,
}
```

### 2. OwnedSlice Missing Bounds Validation (CRITICAL - Memory
Corruption)
**File:** `vortex-io/src/io_buf.rs`  
**Problem:** No bounds checking on slice ranges, allowing buffer
overruns and undefined behavior.
**Solution:** Added comprehensive bounds validation and debug
assertions.
```rust
assert!(range.start <= range.end, "Invalid range");
assert!(range.end <= self.bytes_init(), "Range exceeds buffer length");
```

### 3. CompioDispatcher Arbitrary Timeout (HIGH - Query Failures)
**File:** `vortex-io/src/dispatcher/compio.rs`  
**Problem:** 30-second timeout killed long-running queries.  
**Solution:** Removed timeout, added proper shutdown signaling with
`Arc<AtomicBool>`.

### 4. Buffer Size Integer Overflow (MEDIUM - Panic Risk)
**File:** `vortex-io/src/io_buf.rs`  
**Problem:** Unchecked multiplication could overflow for large buffers.
**Solution:** Added checked arithmetic.
```rust
self.len()
    .checked_mul(size_of::<T>())
    .vortex_expect("Buffer size calculation overflow")... (continued)

589 of 597 new or added lines in 7 files covered. (98.66%)

54342 of 62693 relevant lines covered (86.68%)

540432.85 hits per line