rust-bitcoin / rust-bitcoin / 16891243172

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4801: Move `CheckedData` to `p2p` crate

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/49089585d42f02da0e9f7bddc8ff924322ea458c">49089585d<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/bd64c76f2bbb277cc02a7375c69cb4d9810f44ce"> Move CheckedData to p2p (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c1e8c56216f3c83e92c6e34e2a32745e6e4ae5d9">c1e8c5621</a> Use BlockHash to test serialization behaviour (Tobin C. Harding)

Pull request description:

  Patch 1 is at semi-trivial test change, preparation for patch 2.
  
  At first blush the `CheckedData` type looks like a general purpose checksum abstraction - it is the first four bytes of the `sha256d` hash of a byte vector. However, in this repo it is only ever used in `p2p` so the argument could be made that it is a checksum abstraction defined and used by the Bitcoin p2p layer.
  
  Furthermore the `CheckedData` type introduces a dependency on `hashes`, we are about to separate out the consensus encoding traits into a new crate and it would be nice to avoid a dependency on `hashes`.
  
  In preparation for moving the consensus encoding logic into a new crate move the `CheckedData` type to the `p2p` crate.
  
  If we later find the checksum abstraction useful outside of p2p we can move or duplicate it with little maintenance burden or API bother.


ACKs for top commit:
  apoelstra:
    ACK 49089585d42f02da0e9f7bddc8ff924322ea458c; successfully ran local tests


Tree-SHA512: 24e539e93d58fac9b0e318a89416503f51d

Coverage Stats

52 of 55 new or added lines in 2 files covered. (94.55%)

8 existing lines in 2 files now uncovered.

21541 of 25839 relevant lines covered (83.37%)

15048.47 hits per line