rust-bitcoin / rust-bitcoin / 16885861751

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4806: Remove serde impls from some primitive types

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5a55967e0f774731d02f8d34ccccb4d05d8cfb7f">5a55967e0 Remove serde impls from some primitive types (Tobin C. Harding)

Pull request description:

  Remove `serde` impls for anything that is not one of the following:
  
  - Already has a custom impl
  - The derive is obvious and not likely to change i.e., its a simple
    wrapper type (implies the getter just returns the inner type).
  
  Explicitly this removes `serde` impls from:
  
  - `Block`
  - `block::Header`
  - `Transaction`
  - `TxIn`
  - `TxOut`
  
  Note that these can still be serde de/serialized using consensus encoding. Currently only by using `bitcoin` but if/when `consensus_encoding` crate comes into existence we can add support there as is done currently in `bitcoin::consensus::serde`.
  
  
  Close: #3034


ACKs for top commit:
  apoelstra:
    ACK 5a55967e0f774731d02f8d34ccccb4d05d8cfb7f; successfully ran local tests


Tree-SHA512: bceb0d6623f6a84299297ad9c90a9b1521b

21533 of 25824 relevant lines covered (83.38%)

15097.54 hits per line