tarantool
/
tarantool
/
16884172695
87%
master: 88%
master: 88%
|
Ran
|
Jobs
1
|
Files
514
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
coverage: 87.418% (-0.03%) from 87.444%
push
github
sergepetrenkojournal: check present of prev_entry in the queue On cascading rollback it is necessary to rollback in a reversed order all the entries, ending with the one, which caused the rollback. The entries in the journal space-waiting queue are linked using stailq. So cutting the tail of it to roll it back is not so simple. Need to know the previous entry so as to cut all the next ones. The previous entry is saved before a next entry is added to the queue. So on a rollback the previous entry is already known. But it might happen, that by the time a rollback starts, the previous entry is already gone. For example, it got enough space and went to WAL, removing itself from the journal space-waiting queue. Then such an entry becomes not usable. It is at least for sure is not in the list anymore. And might even be freed already. Luckily, it is easy to check if the prev entry is valid. Lets do that. When the prev entry is gone, it can only be possible when the current entry became the first one. Then can just rollback the entire queue. Closes #11712 Part of #11180 NO_DOC=bugfix NO_CHANGELOG=was not released (cherry picked from commit 86fab9895)
69116 of 122423 branches covered (56.46%)
5 of 5 new or added lines in 1 file covered. (100.0%)
104 existing lines in 21 files now uncovered.101759 of 116405 relevant lines covered (87.42%)
1804397.95 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 29 |
89.7 |
0.02% | src/box/wal.c |
| 15 |
91.94 |
-2.33% | src/box/memtx_space.c |
| 9 |
88.14 |
-7.63% | src/box/vy_regulator.c |
| 7 |
87.88 |
2.39% | src/box/lua/ctl.c |
| 7 |
94.66 |
-1.44% | src/box/vy_read_iterator.c |
| 5 |
94.95 |
0.9% | src/box/journal.c |
| 4 |
90.49 |
-0.3% | src/box/applier.cc |
| 4 |
87.16 |
-0.27% | src/box/vy_run.c |
| 4 |
81.82 |
-12.12% | src/lua/minifio.c |
| 3 |
93.72 |
-0.48% | src/box/txn_limbo.c |
| 3 |
85.61 |
-1.08% | src/lib/core/coio.c |
| 3 |
92.84 |
-0.29% | src/lib/core/fiber.c |
| 3 |
97.05 |
-0.1% | src/lib/msgpuck/msgpuck.h |
| 1 |
95.96 |
-0.18% | src/box/relay.cc |
| 1 |
92.34 |
0.05% | src/box/vinyl.c |
| 1 |
88.05 |
-0.16% | src/box/vy_lsm.c |
| 1 |
95.74 |
0.0% | src/box/vy_range.c |
| 1 |
90.38 |
-1.77% | src/lib/core/trigger.cc |
| 1 |
97.4 |
-0.06% | src/lib/salad/bps_tree.h |
| 1 |
89.39 |
-1.52% | src/lib/small/small/lsregion.c |
| 1 |
96.55 |
-0.86% | src/lib/vclock/vclock.c |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 16884172695.1 | 514 |
87.42 |
GitHub Action Run |
