rust-bitcoin / rust-bitcoin / 16866877666

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4762: Implement `Encodable`/`Decodable` for list of `u8`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/c2b6cf980fc8ad823993c262ed6e45c362b8c7d3">c2b6cf980 Implement Encodable/Decodable for list of u8 (Tobin C. Harding)

Pull request description:

  Currently we have a macro that implements for a vector of a bunch of types, also we implement manually for `Vec<u8>`. This was done because of the lack of specialization in Rust. However we can check the type ID of the generic type at run time and switch on it.
  
  Implement both traits using `TypeId` to dynamically run separate code blocks for `u8` vs any other type. 
  
  NOTE: Introduces a single line usage of `unsafe`.


ACKs for top commit:
  apoelstra:
    ACK c2b6cf980fc8ad823993c262ed6e45c362b8c7d3; successfully ran local tests


Tree-SHA512: 4fa18171a0d5801114e969ee694b89fab23

21588 of 25856 relevant lines covered (83.49%)

15121.58 hits per line