go-pkgz / routegroup / 16864812405

98%

Build Type

push

github

Committed by web-flow

Commit Message

Fix issue #24: Empty Request.Pattern and double middleware execution (#25)

* Fix double middleware execution and empty Request.Pattern (#24)

This fixes two related issues:
1. Middleware was being called twice on root group with path params
2. Request.Pattern was empty when global middlewares executed

Root cause: middlewares were being applied both at route registration
time (in wrapMiddleware) and at serve time (via wrapGlobal).

The fix:
- Modified wrapMiddleware to skip applying middlewares for root bundle
  routes since they're applied globally in ServeHTTP
- Create a shallow copy of the request with Pattern set before applying
  global middlewares, ensuring middlewares can see the pattern
- Updated minimum Go version to 1.23 (required for setting Request.Pattern)

Added comprehensive tests to verify:
- Middleware is called exactly once
- Request.Pattern is properly set throughout the request lifecycle
- Multiple middlewares all see the correct pattern
- Both routes with and without path parameters work correctly

* Address review feedback: simplify code and fix outdated comment

- Remove outdated comment about disabling root not-found handler
- Simplify wrapMiddleware start-index logic for better readability
  by putting early return first and clarifying the child bundle logic

* Add comprehensive middleware tests

- Test PathValue accessibility in middlewares (documents expected behavior)
- Test middleware abort patterns for auth/security
- Test With() method middleware counting to prevent double execution
- Test response writer interception for logging/metrics
- Test context propagation through middleware chain
- Test middleware request property modifications

These tests ensure critical middleware behaviors are properly covered
to prevent regressions like issue #24.

* Simplify HandleRoot and HandleRootFunc comments

- Remove overly verbose and duplicated documentation
- Keep essential information in concise format
- Improve readability with... (continued)

Run Details

16 of 17 new or added lines in 1 file covered. (94.12%)

1 existing line in 1 file now uncovered.

177 of 181 relevant lines covered (97.79%)

48.52 hits per line