vortex-data / vortex / 16839690806

88%

push

github

chore: improve vortex-mask testing (#4178)

# vortex-mask Test Coverage Improvements

## Summary

We've made significant improvements to the test coverage and code
quality of the `vortex-mask` crate. Here's a comprehensive summary:

### 📊 Test Coverage Improvements

- **Increased from 15 to 105 tests** - a 7x increase in test coverage
- **Added 1,183 lines** (mostly tests), removed 109 lines (moved tests)
- All tests pass with no clippy warnings

### 🔧 Key Changes Made

#### 1. Test Organization

- **Moved tests from `lib.rs` to dedicated `tests.rs` file** - Better
separation of concerns
- Added `rstest` as a dev dependency for parameterized testing
- Added file-scoped clippy allows for test code
(`#![allow(clippy::panic)]`,
`#![allow(clippy::many_single_char_names)]`)

#### 2. Comprehensive Test Coverage Added

**bitops.rs** (282 new lines):
- All combinations of `BitAnd` operations (AllTrue, AllFalse, Values)
- `Not` operations for all mask variants
- Boolean algebra property tests:
  - Associativity, commutativity, identity, annihilator, idempotence
  - De Morgan's law validation
  - Double negation
- Edge cases (empty masks, different lengths)

**eq.rs** (113 new lines):
- Equality tests for different lengths, true counts, positions
- Reflexive, symmetric, and transitive properties
- Empty mask behavior
- Different internal representations with same logical values

**intersect_by_rank.rs** (97 new lines):
- Parameterized tests using rstest for special cases
- Edge cases (all true/false combinations)
- Pattern-based tests (single element, alternating, consecutive)
- Panic test for wrong length inputs

**tests.rs** (new file, 673 lines):
- All tests from lib.rs moved here
- Extensive coverage of mask creation, properties, operations
- Caching behavior verification
- `AllOr` enum tests
- FromIterator implementations
- Invalid input panic tests

#### 3. Code Improvements

**lib.rs optimizations**:
- **Fixed `from_excluded_indices`** to return optimize... (continued)

674 of 682 new or added lines in 5 files covered. (98.83%)

51446 of 60372 relevant lines covered (85.22%)

561312.07 hits per line