Qiskit / qiskit / 16837695320

88%

Build Type

push

github

Committed by web-flow

Commit Message

Add Target::add_instruction() check for number of params (#14842)

* Add Target::add_instruction() check for number of params

This commit adds a validation check to the Target::add_instruction()
method that the number of parameters for the given instruction is
correct. Right now there is no validation of this so you could
incorrectly construct a target that had parameters defined for a gate
that doesn't take any. You would only notice this if you went to use the
gates from the target later during transpilation and would get weird
errors about parameters not being valid for certain things
(ask me how I know). This just adds a simple sanity check similar to
how there was existing qargs validation already but just for parameters
too.

* Add a test for gate with params but different count

Run Details

55 of 59 new or added lines in 1 file covered. (93.22%)

23 existing lines in 3 files now uncovered.

82344 of 93949 relevant lines covered (87.65%)

545525.57 hits per line