SwissDataScienceCenter / renku-data-services / 16827567311

86%

push

github

fix: patch user secrets init container on resume (#934)

Closes #917.

Details:
* Refactors `components/renku_data_services/notebooks/blueprints.py` -> the start session logic is moved to `components/renku_data_services/notebooks/core_sessions.py`. This means that `start_session()` and `patch_session()` are defined in the same file next to each other.
* Add a new `SessionExtraResources` dataclass model: it is used to accumulate session resources during start or patch so that it is easier to define the new Amalthea session or to define the patch upon resume.
* The start and patch logic are now more similar to each other, which should make differences or bugs easier to spot.
* With the logic updated, we now make sure to also refresh the definition of the user secrets init container, which fixes #917.

46 of 177 new or added lines in 5 files covered. (25.99%)

21690 of 24889 relevant lines covered (87.15%)

1.53 hits per line