go-pkgz / routegroup / 16825352665

98%

Build Type

push

github

Committed by web-flow

Commit Message

Fix HTTP 405 Method Not Allowed responses (#21)

* Fix HTTP 405 Method Not Allowed responses

This change fixes incorrect HTTP status code handling where wrong HTTP methods
on existing routes were returning 404 Not Found instead of 405 Method Not Allowed.

Key changes:
- Remove automatic catch-all route registration that was intercepting requests
- Apply root middlewares at serve time instead of route registration time
- Preserve standard library's HTTP method matching behavior
- Add middleware ordering enforcement with panic on misuse
- Maintain backward compatibility with DisableNotFoundHandler as no-op

The new architecture properly distinguishes between:
- 404 Not Found: path doesn't exist
- 405 Method Not Allowed: path exists but method not supported

This preserves HTTP semantics while still allowing global middleware application
and custom 404 handlers when needed.

* Fix improper defer usage in test loops

Replace defer statements inside loops with explicit Close() calls
at the end of each iteration. Using defer in loops causes all
deferred calls to accumulate until function exit, potentially
causing resource leaks with many iterations.

Also properly handle Close() errors instead of ignoring them.

* Clarify that custom NotFoundHandler receives global middlewares

Add explicit documentation that custom 404 handlers have the root
bundle's global middlewares applied to them, ensuring consistency
with the overall middleware application design.

Run Details

63 of 70 new or added lines in 1 file covered. (90.0%)

7 existing lines in 1 file now uncovered.

165 of 172 relevant lines covered (95.93%)

28.8 hits per line