rust-bitcoin / rust-bitcoin / 16814018560

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4773: feat(p2p): make the p2p crate no_std

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/7a3af7a07b0c99e6568a018db7d630791bef528b">7a3af7a07 feat(p2p): make the p2p crate no_std (Nick Johnson)

Pull request description:

  Establish the `std` feature flag on the crate and make it the default so no change for users. This makes current and future features of the crate explicitly std or alloc dependent which I think will keep us honest moving forward. This started as just an exploration as to how hard would it be to make the crate no_std, but looks pretty straight forward. This matches the other crates in the workspace and I don't think we should be leaning more into OS-dependent things in this crate vs the others.
  
  The crate is actually pretty close to being no_std. The big tie to std is the IP types in the std net module, but those are moved to core in rust 1.77. There was some exploration to make the net types no_std in https://github.com/rust-bitcoin/rust-bitcoin/pull/4525, but I took the easy out for now and just feature flagged the modules.


ACKs for top commit:
  tcharding:
    ACK 7a3af7a07b0c99e6568a018db7d630791bef528b
  apoelstra:
    ACK 7a3af7a07b0c99e6568a018db7d630791bef528b; successfully ran local tests


Tree-SHA512: e4c8ebe3b63108ba8fbca847a0ac25fa4d8

21545 of 25817 relevant lines covered (83.45%)

15119.58 hits per line