spesmilo / electrum / 5323198578819072

61%

master: 63%

Build Type

Pull #10111

CirrusCI

Committed by SomberNight

Commit Message

interface: don't request same tx from server that we just broadcast to it

Often when the wallet creates a tx, the flow is:
- create unsigned tx
- sign tx
- broadcast tx, but don't save it in history
- server sends notification that status of a subscribed address changed
- client calls scripthash.get_history
- client sees txid in scripthash.get_history response
- client calls blockchain.transaction.get to request missing tx

Instead, now when we broadcast a tx on an interface, we cache that tx *for that interface*,
and just before calling blockchain.transaction.get, we lookup in the cache.
Hence this will often save a network request.

Pull Request Pull Request #10111: interface: don't request same tx from server that we just broadcast to it

Run Details

103 of 185 new or added lines in 3 files covered. (55.68%)

113 existing lines in 47 files now uncovered.

22450 of 36892 relevant lines covered (60.85%)

2.43 hits per line