vortex-data / vortex / 16809286174

88%

Build Type

push

github

Committed by web-flow

Commit Message

chore: improve vortex-scalar tests, reorganize module structure (#4145)

## Overview

This comprehensive refactoring improved test coverage, fixed critical
bugs, enhanced code organization, and improved consistency across the
vortex-scalar crate.

## Major Bug Fixes

  1. Fixed Decimal Casting Panic (lib.rs:231)
    - Replaced todo!() with proper decimal casting implementation
- Added support for decimal-to-primitive and decimal-to-decimal
conversions
    - Handles scale conversions correctly
2. Fixed ByteBuffer Null Conversion Panic (scalar_value/binary.rs:18-19)
- Changed from .vortex_expect() (panics) to .ok_or_else() (returns
error)
    - Prevents runtime panics when converting null scalars to ByteBuffer
  3. Fixed i256 BigInt Implementation (bigint/mod.rs)
    - Added comprehensive tests and fixed edge cases
    - Improved arithmetic operations and comparisons

## Module Reorganization

  1. Arrow Module (arrow.rs → arrow/mod.rs + arrow/tests.rs)
    - Split into directory module with separate test file
    - Added 262 lines of comprehensive conversion tests
2. Decimal Module (decimal.rs → decimal/mod.rs + decimal/tests.rs +
decimal/value.rs)
    - Reorganized into directory module with 3 files
    - Added 495 lines of tests covering edge cases
    - Separated DecimalValue into its own module (303 lines)
  3. Test Organization (new tests/ directory)
    - Created tests/core.rs (563 lines) - core functionality tests
    - Created tests/round_trip.rs (329 lines) - serialization tests
- Created tests/consistency.rs (131 lines) - documenting inconsistencies
    - Created tests/mod.rs - module organization

## Consistency Improvements

  1. Null Comparison Behavior
    - Standardized across BoolScalar, BinaryScalar, Utf8Scalar
    - All now use dtype.eq_ignore_nullability() for comparisons
  2. Error Messages
    - Consistent error message format using vortex_err!
    - Better error context throughout
  3. Trait Implementations
    - Added missing Fro... (continued)

Run Details

1851 of 1939 new or added lines in 23 files covered. (95.46%)

3 existing lines in 3 files now uncovered.

50168 of 59212 relevant lines covered (84.73%)

552637.38 hits per line