supabase / supabase-js / 16799791196

80%

push

github

fix: avoid Next.js Edge Runtime warnings in Node.js deprecation check (#1520)

* fix: avoid Next.js Edge Runtime warnings in Node.js deprecation check

Use dynamic property access for process.version to prevent Next.js static
analysis from flagging the code as incompatible with Edge Runtime.

The deprecation warning logic remains unchanged - it only runs in actual
Node.js environments and is properly guarded against Edge Runtime execution.

Fixes #1515

* fix: restore undefined and null checks for process.version

Maintain the original defensive programming checks while still using
dynamic property access to avoid Edge Runtime warnings

* test: add comprehensive tests for Node.js deprecation warning

- Test browser environment detection
- Test Edge Runtime compatibility (no process object)
- Test various process.version states (undefined, null, invalid)
- Test version detection for Node.js 16, 18, 20, 22
- Test invalid version format handling

* fix: update deprecation tests to work with TypeScript isolatedModules

- Add export {} to make file a module
- Remove problematic test for undefined process (dependencies require it)
- Add comment explaining why Edge Runtime scenario is hard to test in Node

* test: eliminate TTYWRAP warnings in deprecation tests

Use Object.defineProperty to mock only process.version instead of
spreading the entire process object. This avoids copying TTY handles
and other complex properties that cause Jest warnings.

65 of 104 branches covered (62.5%)

Branch coverage included in aggregate %.

6 of 7 new or added lines in 1 file covered. (85.71%)

122 of 146 relevant lines covered (83.56%)

34.01 hits per line