bitcoindevkit / bdk / 16794659338

79%

push

github

Merge bitcoindevkit/bdk#1998: refactor!: `Box` the changeset of `StoreErrorWithDump`

<a class=hub.com/bitcoindevkit/bdk/commit/418753f01eef29b1266cc3aefa512f90060a9797">418753f01 refactor!: `Box` changeset in `StoreErrorWithDump` (codingp110)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description
  Fixes #1991. As the linked issue mentions `Box`ing helps reduce memory overhead and [limits the size of enums with `StoreErrorWithDump` as variant](https://github.com/bitcoindevkit/bdk_wallet/pull/277#discussion_r2196831262).

  Breaking: The enum `StoreErrorWithDump` and the functions `load`,`dump` and `load_or_create` have been changed.

  ### Changelog Notice
  ```
     Changed
     - `changeset` field of `StoreErrorWithDump` is now of type `Option<Box<C>>`
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  evanlinjin:
    ACK 418753f01eef29b1266cc3aefa512f90060a9797

Tree-SHA512: c09d2b14980b07e42836441c02bfb0e4e26

384 of 522 branches covered (73.56%)

Branch coverage included in aggregate %.

4 of 5 new or added lines in 1 file covered. (80.0%)

4281 of 5391 relevant lines covered (79.41%)

2268.61 hits per line