tari-project / tari / 16785949760

62%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add seed peer exclusion to network discovery (#7395)

Description
---
Added seed peer exclusion to network discovery's `Discovering` mode
(`impl DiscoveryReady`) when seed strap has been concluded.

Motivation and Context
---
It is counterproductive to dial seed peers to discover other peers after
seed strap has been concluded, as this requires asking for the same
information again.

How Has This Been Tested?
---
- System-level testing confirming that seed peers are not redialed as
part of `Discovering` mode.

What process can a PR reviewer use to test or verify this change?
---
- Code review.
- System-level testing.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
* Added support for filtering peers by flags when selecting closest or
random peers, allowing more granular peer selection.

* **Bug Fixes**
* Updated peer selection methods throughout the application to accept
and handle the new optional peer flag parameter, ensuring consistent
behavior.

* **Tests**
* Introduced new tests to verify correct peer selection when filtering
by specific flags.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Run Details

171 of 173 new or added lines in 8 files covered. (98.84%)

9 existing lines in 3 files now uncovered.

75694 of 139558 relevant lines covered (54.24%)

195447.15 hits per line